Drupal 9 is almost here and Open Social should be compatible with Drupal 9.
In Open Social there's still a lot of deprecated code that is used, this should all be replaced.
We could use the deprecation checks and correction tools as suggested here: https://www.drupal.org/docs/9/how-to-prepare-your-drupal-7-or-8-site-for....
Let's use this issue ticket to do an initial check of what is required to be compatible with Drupal 9. Depending on the amount of work child issues can be created.
Issue fork social-3134077
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
bramtenhove CreditAttribution: bramtenhove at Open Social for Open Social commentedComment #3
KingdutchLets make sure this issue can be found
Comment #4
ronaldtebrake CreditAttribution: ronaldtebrake as a volunteer and at Open Social for Open Social commentedWe are using: https://www.drupal.org/docs/updating-drupal/how-to-prepare-your-drupal-7...
Work in progress here:
https://github.com/goalgorilla/open_social/pull/1969
Comment #5
ronaldtebrake CreditAttribution: ronaldtebrake as a volunteer and at Open Social for Open Social commentedWe have checked all the modules for their D9 compatibility, and below you'll see a list of Compliant modules, modules that require an update, or modules that require a patch / work to get D9 compatibility.
Good news is that most modules have compatible version available, and we will start updating these modules towards their compatible versions.
Needs work Project
Patch AJAX Comments
Patch Data Policy
Patch Field Group
Patch KPI Analytics
Patch Like & Dislike
Patch Link CSS
Patch Message
Patch Redirect 403 to User Login
Patch Private Message
Remove Features
Update Address
Update Admin Toolbar
Update Better Exposed Filters
Update Block Field
Update Bootstrap
Update CAPTCHA
Update Chaos Tools
Update Configuration Update Base
Update Crop API
Update DataBase Email Encryption
Update Devel
Update Disable user 1 edit
Update Dynamic Entity Reference
Update Encrypt
Update Entity
Update Entity Reference Revisions
Update File metadata manager
Update Flag
Update Gin
Update Google Analytics
Update Group
Update Image Effects
Update ImageWidgetCrop
Update Key
Update Lazy-load
Update Login Tracker
Update Metatag
Update Override Node Options
Update Paragraphs
Update Pathauto
Update Redirect
Update Search API
Update Select2
Update Serialization (CSV)
Update Shariff Sharing Buttons
Update Swift Mailer
Update Token
Update Update Helper
Update Views Bulk Operations
Update Views Infinite Scroll
Update Voting API
Also we are starting to make sure our own code is Drupal 9 compatible here:
https://github.com/goalgorilla/open_social/pull/1969
Comment #6
kokrull CreditAttribution: kokrull commentedalphabetically I managed to get most modules updated in my trials apart from the group stuff, things started falling over at that point and I decided to wait for you guys, :)
thanks for the heads up and thanks for the work so far..
cheers
Comment #7
ronaldtebrake CreditAttribution: ronaldtebrake as a volunteer and at Open Social for Open Social commentedOur code is now Drupal 9 compatible. Please see - https://github.com/goalgorilla/open_social/pull/2144
In order to get there:
We have added drupal core compatibility to our info.yml files to show all our custom work is compatible by using
core_version_requirement: ^8.8 || ^9
We have ensured to remove all deprecated code which is removed from Drupal 9. The replacement code is compatible with Drupal 8.9 as well so untill all our contributed modules are Drupal 9 ready, we are still installing Drupal 8.9.
We have added phpstan as a github action, to make sure we wont be using any deprecated code anymore either. All new code will be ran at lvl 5 strictness as well, to ensure our code is also hold to a higher standard.
We will update our modules in a separate story and hopefully get to Drupal 9 soon.
Comment #10
navneet0693 CreditAttribution: navneet0693 as a volunteer and commentedThe changes are now present in 10.0.x branch and will be included in release of 10.0 and above.
Comment #11
vishtg CreditAttribution: vishtg commentedhi, i have installed the open social 10 version.
Looks great.
How can i make it install drupal 9 core. Right now it is install the d8 version.
Comment #13
ytsurkFrom the roadmap:
To install D9 upfront you need to deal with the not yet ready modules yourself ...
#3106217: what is the plan of open social for drupal 9?
Comment #14
bas123 CreditAttribution: bas123 as a volunteer and commentedBy my own admission, I have not checked my add on modules to my OS distributions, most of which (less a few) are all compatible with ^9.0 in a few weeks.
And @ronaldtebrake has kindly listed all of the OS compatible modules above that also are, along with the project's code!
However, the move to OS 10 has left us with several modules that were removed from OS by reasons claimed that they were burdensome to the project or created performance issues such as Search Auto Fill and SSO Social Auths etc.
This is fair and indeed none of us that have added our own modules should expect any more of the OS Team in insuring compatibility with those that they never included in the project.
However, regarding those projects that WERE part of the project and have been depreciated in the version 10, I believe it is still incumbent upon the Open Social Team to proactively assist (which they have been so far) in helping those of us struggling with carryover issues regarding those modules ESPECIALLY, if (like the Social Auth or Search Auto Compete), we would like to continue their use.
Advising on the reasons for dropping those modules if it involves Drupal 9 incompatibility (alone or in addition to) should be disclosed as well as any other reasons why they were dropped!
I believe that is only fair, and I hope agreed!
Comment #16
Sebastian HagensHi,I've just downloaded a clean Drupal 9 site with composer
composer create-project drupal/recommended-project dir
and installed it with Drush.
composer require drupal/social
gives me the following message
This is the composer.json file
Never mind, I've just read the comments. Please delete this comment.
Comment #17
ronaldtebrake CreditAttribution: ronaldtebrake as a volunteer and at Open Social for Open Social commentedAdded follow up task where we will work on updating/patching our contrib modules.
Comment #18
vishtg CreditAttribution: vishtg commentedhello guys,
nice work
are we on drupal 9 yet please?
Thanks
Comment #19
bas123 CreditAttribution: bas123 as a volunteer and commented@vishtg,
It would be most valuable for you to read each of the comments in this issue for context!
Then read the Related issues provided in #17 (directly above your request):
https://www.drupal.org/project/social/issues/3207776
Comment #20
kokrull CreditAttribution: kokrull commentedquestion. doesn't Drupal 9.x require PHP 7.4 ("currently" 'they' plan for 8) but open social requires PHP 7.3? fairly sure someone mentioned OS requiring 7.3 not long back. i know my main dev site fell over when i tried it. The admin area seemed to work as i recall but i ran a restore point shortly after that so could be wrong
admintoolbar has been error-free in my test sites throughout so i have a fuzzy memory of the admin area working. will check if you like, i still have the save point
cheers
Comment #21
vishtg CreditAttribution: vishtg commentedhello @bas123.
Thank you for pointing me to the right thread.
Sorry i didnt notice the link although i had been following all news on this matter.
cheers