Fix SDP mangling in DTMF and add a test #767
Conversation
|
Turns out the SDP manging code is no longer needed ;). The issues still remain however they seem to be unrelated to DTMF as I can reproduce them on other samples. |
|
OK so the choppy audio on M50 was temporary, after a crash when trying to create an aecdump it now sounds OK. Still investigating the M51 issue, however as mentioned it's unrelated to this change. |
|
Interesting, it works fine in the tests on all Chrome channels....Maybe some local issue related to my profile.... |
KaptenJansson
changed the title
|
@samdutton PTAL when you get a chance. |
|
PTAL @hkjellander |
| /* eslint-env node */ | ||
|
|
||
| 'use strict'; | ||
| // This is a basic test file for use with testling. |
There was a problem hiding this comment.
testling -> testing.
There was a problem hiding this comment.
i think this was testling but we moved away from testling to selenium
There was a problem hiding this comment.
@KaptenJansson should we delete that line everywhere?
There was a problem hiding this comment.
Yes that should be removed.
|
Is there an easy way I can try out the fixed page or do I have to patch a fork and use that? |
| .then(function() { | ||
| return driver.wait(function() { | ||
| return driver.executeScript( | ||
| // For some reason the demo sends and extra space. Assume its due to |
|
fork (assuming nodejs is installed) and run ´node test/server.js´ then browse to ´https://localhost:8080/´ |
|
LGTM, I assume you'll fix the testling references for all tests in another PR (I wasn't aware it was the name of a test framework ;) |
Description
Update the SDP mangling code.
Fixes #752
Purpose
Fix the DTMF demo
One curious thing though, testing on Stable, Beta and Dev yields 3 different results.
Will continue investigating and commit to this PR.
CC @tednakamura