New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Blogger (blogspot.com) importer #162
Conversation
…replace-internal-link
…blogger-info and --replace-internal-link
…mport blogger Usage: jekyll import blogger [options] Options: --source NAME The XML file (blog-MM-DD-YYYY.xml) path to import --no-blogger-info Leave blogger-URL info (id and old URL.) as YAML data (default: false) --replace-internal-link Whether to replace internal links with the post_url liquid codes (default: false) -h, --help Show this message -v, --version Print the name and version -t, --trace Show the full backtrace when an error occurs
@@ -0,0 +1,263 @@ | |||
require 'rexml/streamlistener' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be placed in require_deps
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing the line cause an error on include REXML::StreamListener
on BloggerAtomStreamListener
class.
I have no idea how to do same without require
...
Looks great! I'd gladly merge if you address my 2 comments and fix the tests, please. Thanks! |
Two 'the in-elem-entry-to-post-data converter should raise an error if original_url not exists.' exists (duplicated). So the 2nd test is replaced with '...should raise an error if non-post-kind not exists'. In addition, fix the 1st test.
…e `require_deps` instead of `require`
I wonder if the changeset cd3980a is OK wrt coding rule... |
It is perfect! Just so you know, I'll be coming back to you if people come asking about this code 😄 Thanks so much for your contribution!! |
I created a Blogger-to-Jekyll importer.
Would you capture my importer?