Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protect: return a 401 error code on the math collection page. #5551

Merged
merged 2 commits into from Dec 8, 2016
Merged

Protect: return a 401 error code on the math collection page. #5551

merged 2 commits into from Dec 8, 2016

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Nov 8, 2016

@jeherve jeherve added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Protect Also known as Brute Force Attack Protection [Status] Needs Review To request a review from Crew. Label will be renamed soon. [Pri] Normal labels Nov 8, 2016
@jeherve jeherve added this to the 4.5 milestone Nov 8, 2016
farcaller
farcaller reviewed Nov 8, 2016
View reviewed changes
modules/protect/math-fallback.php
@@ -83,7 +83,11 @@ static function generate_math_page( $error = false ) {
<?php
$mathage = ob_get_contents();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be a good time to fix the mathage -> mathpage typo too.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, I didn't even notice! Fixed in d91cf61

@dereksmart dereksmart added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Dec 7, 2016
@samhotchkiss samhotchkiss merged commit 90577bf into master Dec 8, 2016
@samhotchkiss samhotchkiss deleted the fix/fatal-protect-die branch December 8, 2016 03:33
@kraftbj kraftbj removed the [Status] Ready to Merge Go ahead, you can push that green button! label Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@farcaller farcaller farcaller left review comments

Assignees
No one assigned
Labels
[Feature] Protect Also known as Brute Force Attack Protection [Pri] Normal [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
4.5
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jeherve @farcaller @kraftbj @samhotchkiss @dereksmart