Closed
Bug 735615
Opened 12 years ago
Closed 12 years ago
Remove AutoClean from mozglue/linker/Utils.h
Categories
(Core :: mozglue, defect)
Tracking
()
RESOLVED
FIXED
mozilla17
People
(Reporter: Yoric, Assigned: drexler)
References
Details
(Whiteboard: [mentor=Yoric][lang=c++])
Attachments
(1 file)
12.65 KB,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
Now that we have generic RAII helpers in MFBT, we should get rid of the corresponding original code in mozglue/linker/Utils.h, which does not compile with VC++.
Reporter | ||
Comment 1•12 years ago
|
||
Note: to test that it does not break faulty.lib, add |export MOZ_LINKER=1| to mozconfig and build on Linux desktop.
Reporter | ||
Comment 2•12 years ago
|
||
Actually, it looks like a good candidate for mentored bugs.
Component: XPCOM → XP Toolkit/Widgets: Menus
QA Contact: xpcom → xptoolkit.menus
Whiteboard: [mentor=Yoric][lang=c++]
Updated•12 years ago
|
Component: XP Toolkit/Widgets: Menus → mozglue
OS: Mac OS X → Android
QA Contact: xptoolkit.menus → mozglue
Hardware: x86 → ARM
Assignee | ||
Updated•12 years ago
|
QA Contact: andrew.quartey
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → andrew.quartey
QA Contact: andrew.quartey
Assignee | ||
Comment 3•12 years ago
|
||
Attachment #646882 -
Flags: review?(dteller)
Assignee | ||
Updated•12 years ago
|
QA Contact: mozglue
Comment 4•12 years ago
|
||
Comment on attachment 646882 [details] [diff] [review] patch I'll take this review
Attachment #646882 -
Flags: review?(dteller) → review?(mh+mozilla)
Updated•12 years ago
|
Attachment #646882 -
Flags: review?(mh+mozilla) → review+
Assignee | ||
Comment 5•12 years ago
|
||
Sent to inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/3c34aa0c81f7
Status: NEW → ASSIGNED
Comment 6•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/3c34aa0c81f7
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in
before you can comment on or make changes to this bug.
Description
•