David Bruant Reporter
	Description • 13 years ago

These functions have been obseleted in Gecko 1.9 (Firefox 3) https://developer.mozilla.org/en/Gecko_1.9_Changes_affecting_websites#A_few_other_old_event_APIs_are_no_longer_supported


I have discovered them today randomly by traversing the global object on a webpage.
After research, these functions are not seems standard from what I've seen. I've never heard of anyone using them in code.
Bug 132132 asks for removal and is solved as duplicate of Bug 330494. Yet, I still see these properties on the global object in the webconsole and Firebug

	Boris Zbarsky [:bzbarsky]
	Comment 1 • 13 years ago

> and is solved as duplicate of Bug 330494

Which it's not.  The guy who did that confused deprecation and removal.

Olli, can we remove these now?  I seem to recall some sites using them, but maybe that was a while ago?

	Erik Arvidsson
	Comment 3 • 11 years ago

I intend to remove these from Blink.

	Masatoshi Kimura [:emk] Assignee
	Comment 4 • 11 years ago

Chrome is going to remove them very soon.
https://code.google.com/p/chromium/issues/detail?id=238243
Let's try to follow that.
try: https://tbpl.mozilla.org/?tree=Try&rev=382bbec5b5a1

	Masatoshi Kimura [:emk] Assignee
	Comment 5 • 11 years ago

https://tbpl.mozilla.org/?tree=Try&rev=16c37d946206

	Masatoshi Kimura [:emk] Assignee
	Comment 6 • 11 years ago

Green on try: https://tbpl.mozilla.org/?tree=Try&rev=671d217429b2

	Olli Pettay [:smaug][bugs@pettay.fi]
	Comment 7 • 11 years ago

Comment on attachment 747619 [details] [diff] [review]
Remove captureEvents, releaseEvents, and routeEvent

The crashtest is odd, but ok.

This should land early in a cycle, so could you land this after the next merge, which
happens next week.

	Masatoshi Kimura [:emk] Assignee
	Comment 8 • 11 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/2aa62db58f24

	Ryan VanderMeulen [:RyanVM]
	Comment 9 • 11 years ago

https://hg.mozilla.org/mozilla-central/rev/2aa62db58f24

	Kohei Yoshino [:kohei]
	Comment 10 • 11 years ago

Updated:
https://developer.mozilla.org/en-US/docs/Gecko_1.9_Changes_affecting_websites
https://developer.mozilla.org/en-US/docs/Web/API/document
https://developer.mozilla.org/en-US/docs/Web/API/window
https://developer.mozilla.org/en-US/docs/Web/API/window.captureEvents
https://developer.mozilla.org/en-US/docs/Web/API/window.releaseEvents
https://developer.mozilla.org/en-US/docs/Web/API/window.routeEvent

Added:
https://developer.mozilla.org/en-US/docs/Site_Compatibility_for_Firefox_24

Bug 330494 deprecated preventBubble and preventCapture too but these are still implemented. Is this intended?

	David Bruant Reporter
	Comment 11 • 11 years ago

(In reply to Kohei Yoshino from comment #10)
> Updated:
> https://developer.mozilla.org/en-US/docs/Gecko_1.9_Changes_affecting_websites
> https://developer.mozilla.org/en-US/docs/Web/API/document
> https://developer.mozilla.org/en-US/docs/Web/API/window
> https://developer.mozilla.org/en-US/docs/Web/API/window.captureEvents
> https://developer.mozilla.org/en-US/docs/Web/API/window.releaseEvents
> https://developer.mozilla.org/en-US/docs/Web/API/window.routeEvent
> 
> Added:
> https://developer.mozilla.org/en-US/docs/Site_Compatibility_for_Firefox_24
Thanks for the doc! It all looks good to me.

> Bug 330494 deprecated preventBubble and preventCapture too but these are
> still implemented. Is this intended?
I wish I had noticed these when reporting this bug to add them to the list of things to remove :-/
Filed bug 874003 for this.

	Erik Arvidsson
	Comment 12 • 11 years ago

Unfortunately we had to add them back to Chrome. There is a lot of code out there that starts with:

if (!IE) {
  document.captureEvents();
}

Another data point is that IE11 (which does not identify as IE) had to add it as well.

Sigh.

	Olli Pettay [:smaug][bugs@pettay.fi]
	Comment 13 • 11 years ago

Argh.

Sounds like we need to back out the change and HTML spec needs to be updated.

emk, could you back out the change?

	Olli Pettay [:smaug][bugs@pettay.fi]
	Comment 14 • 11 years ago

https://www.w3.org/Bugs/Public/show_bug.cgi?id=22847

	Jean-Yves Perrier [:teoli]
	Comment 15 • 11 years ago

Switching the doc back to dev-doc-needed to not forget to update the doc (or not) once the decision is taken :-(

	Masatoshi Kimura [:emk] Assignee
	Comment 16 • 11 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/bd49d8389a9b
I couldn't simply backout the changeset because nsIDOMJSWindow and nsIDOMHTMLDocument were changed after this bug.
Also this bug contains a string change. Can I land this patch on Aurora?

	Olli Pettay [:smaug][bugs@pettay.fi]
	Comment 17 • 11 years ago

Upload the patch for Aurora and ask for approval.

	Masatoshi Kimura [:emk] Assignee
	Comment 18 • 11 years ago

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 673919
User impact if declined: A lot of Websites will be broken, according to a report from Google
Testing completed (on m-c, etc.): waiting for merge on m-i
Risk to taking this patch (and alternatives if risky): low, backout.
String or IDL/UUID changes made by this patch: uuid will be reverted but removed strings will be re-added.

	Masatoshi Kimura [:emk] Assignee
	Comment 19 • 11 years ago

uuid change is a simple backout on aurora.

	Masatoshi Kimura [:emk] Assignee
	Comment 20 • 11 years ago

Try removing routeEvent() again. And I bet enableExternalCapture() and disableExternalCapture() are not needed.

	Masatoshi Kimura [:emk] Assignee
	Comment 21 • 11 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/8103ed66ceef

	Masatoshi Kimura [:emk] Assignee
	Comment 22 • 11 years ago

[Approval Request Comment]
See comment #18, modulo:
String or IDL/UUID changes made by this patch: uuid will be reverted. No string change.

Only one of this patch or attachment 784042 [details] [diff] [review] needs an approval.

	Ryan VanderMeulen [:RyanVM]
	Comment 23 • 11 years ago

https://hg.mozilla.org/mozilla-central/rev/8103ed66ceef

	bhavana bajaj [:bajaj]
	Comment 24 • 11 years ago

Comment on attachment 784406 [details] [diff] [review]
Backout patch without reverting string change

PLease make sure the UUID change is backed out as well.

	bhavana bajaj [:bajaj]
	Comment 25 • 11 years ago

Comment on attachment 784042 [details] [diff] [review]
Backout patch for aurora

Approved the alternate patch without the  removal of string's

	Masatoshi Kimura [:emk] Assignee
	Comment 26 • 11 years ago

Sorry, I have no time to watch the tree right now.

	Masatoshi Kimura [:emk] Assignee
	Comment 27 • 11 years ago

Already reverted (and relanded without captureEvents and releaseEvents removal) on Nightly.

	Kohei Yoshino [:kohei]
	Comment 28 • 11 years ago

Updated docs:
https://developer.mozilla.org/en-US/docs/Web/API/document
https://developer.mozilla.org/en-US/docs/Web/API/window
https://developer.mozilla.org/en-US/docs/Web/API/window.captureEvents
https://developer.mozilla.org/en-US/docs/Web/API/window.releaseEvents
https://developer.mozilla.org/en-US/docs/Web/API/window.routeEvent
https://developer.mozilla.org/en-US/docs/Site_Compatibility_for_Firefox_24

	Masatoshi Kimura [:emk] Assignee
	Comment 29 • 11 years ago

https://hg.mozilla.org/releases/mozilla-aurora/rev/4ea223de889c

	Kohei Yoshino [:kohei]
	Comment 30 • 11 years ago

Marking WONTFIX and clearing the keywords to avoid confusion, as the patches have been backed out.

	Masatoshi Kimura [:emk] Assignee
	Comment 31 • 11 years ago

Actually this bug has been morphed to a bug removing releaseEvents, enableExternalCapture, disableExternalCapture (see the Summary change).
Maybe I should have filed a new bug. Sorry for the confusion.

	Masatoshi Kimura [:emk] Assignee
	Comment 32 • 11 years ago

So the documentation should be updated again.

	Kohei Yoshino [:kohei]
	Comment 33 • 11 years ago

Oh, oh...

(In reply to Masatoshi Kimura [:emk] from comment #29)
> https://hg.mozilla.org/releases/mozilla-aurora/rev/4ea223de889c

As per this changeset,
* Still available: captureEvents, releaseEvents
* Removed: routeEvent, enableExternalCapture, disableExternalCapture
so the summary should be corrected here.

	Kohei Yoshino [:kohei]
	Comment 34 • 11 years ago

I mean this changeset on central:
https://hg.mozilla.org/mozilla-central/rev/8103ed66ceef

Updated the docs:
https://developer.mozilla.org/en-US/docs/Web/API/Window.routeEvent
https://developer.mozilla.org/en-US/docs/Site_Compatibility_for_Firefox_24

	Masatoshi Kimura [:emk] Assignee
	Comment 35 • 11 years ago

> Recently Google Chrome (the Blink rendering engine) also removed the support for those methods.

This sentence should be removed because Google Chrome reverted the removal of captureEvents and releaseEvents, and it have never supported the rest from the start.

	Kohei Yoshino [:kohei]
	Comment 36 • 11 years ago

(In reply to Masatoshi Kimura [:emk] from comment #35)
> > Recently Google Chrome (the Blink rendering engine) also removed the support for those methods.
> 
> This sentence should be removed because Google Chrome reverted the removal
> of captureEvents and releaseEvents, and it have never supported the rest
> from the start.

Removed the incorrect sentence. Thanks!

	u279076
	Comment 37 • 11 years ago

Assuming no QA needed here.